Skip to content

Conversation

GuillaumeGomez
Copy link
Member

Fixes #64371.

r? @notriddle

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 1, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 1, 2022
@notriddle
Copy link
Contributor

Any ideas on making Tidy detect this problem?

@GuillaumeGomez
Copy link
Member Author

We have the src/tools/htmlchecker which does that. We ignore a few warnings though. Might be worth checking if we can re-enable some of them.

@notriddle
Copy link
Contributor

I agree, but let's not block this fix on that.

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 2, 2022

📌 Commit 6f3d988 has been approved by notriddle

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2022
@bors
Copy link
Collaborator

bors commented Apr 2, 2022

⌛ Testing commit 6f3d988 with merge b6a34f3...

@bors
Copy link
Collaborator

bors commented Apr 2, 2022

☀️ Test successful - checks-actions
Approved by: notriddle
Pushing b6a34f3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 2, 2022
@bors bors merged commit b6a34f3 into rust-lang:master Apr 2, 2022
@rustbot rustbot added this to the 1.61.0 milestone Apr 2, 2022
@GuillaumeGomez GuillaumeGomez deleted the fix-invalid-dom-generation branch April 2, 2022 18:48
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (b6a34f3): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustdoc generates illegal "<div>" inside "<pre>" with traits
6 participants